Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: Use main output panel for output #6044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

scripts: Use main output panel for output #6044

wants to merge 1 commit into from

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Dec 30, 2024

Overview

  • Use the main Output panel for script output.

Related Issues

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@ricekot ricekot force-pushed the scripts/diff-output branch 2 times, most recently from f2032f0 to 677ff14 Compare December 30, 2024 13:48
@ricekot
Copy link
Member Author

ricekot commented Dec 30, 2024

Rebased on #6041 to make it easier to pull and test.

@psiinon
Copy link
Member

psiinon commented Dec 30, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 5af94f91-f2a6-4398-a7b3-637d9d82fedb

Great job, no security vulnerabilities found in this Pull Request

@ricekot ricekot force-pushed the scripts/diff-output branch from 677ff14 to cea9f7f Compare January 14, 2025 17:41
@ricekot ricekot marked this pull request as ready for review January 14, 2025 17:41
@thc202
Copy link
Member

thc202 commented Jan 15, 2025

I think we should make it clear when there's new output in the tabs (might be something for commonlib though, e.g. icon with some overlay, asterisk, bold title), right now it's difficult to know if any script outputted something new after the tab was shown for the first time.

I'd suggest having the following behaviour (optional?) too:

  • Show the tab on output.
  • Show the corresponding output tab when the script is selected.

The output tab does not have the title updated when the script is renamed and when the script is removed the tab is not removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to differentiate scripts' output
3 participants
@ricekot @psiinon @thc202